This repository was archived by the owner on Jul 6, 2019. It is now read-only.
Fixes PHP Fatal error: Cannot use Underscore\Types\String as String#101
Closed
kenorb wants to merge 1 commit intoAnahkiasen:masterfrom
Closed
Fixes PHP Fatal error: Cannot use Underscore\Types\String as String#101kenorb wants to merge 1 commit intoAnahkiasen:masterfrom
kenorb wants to merge 1 commit intoAnahkiasen:masterfrom
Conversation
|
Note, this is a bad patch. The problem does not exist in this version. Notice the name of the class is "Strings" which is fine. The problem exists in older versions of anahkiasen/underscore-php where it is simply "String" The request from the other ticket was to tag the 1.x branch with the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #96
The error happens in PHP 7.x
E.g.
Ignore the CI tests, as they're basically broken. My attempt to fix them is in #102.